fix: legend default config for multiple chart instances (#110)

* fix: init legend default config * test: add tests for default config instances
SalesforceLabs · May 24, 2022 · 77917a9 · 77917a9
1 parent 30e47ce
commit 77917a9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/__tests__/unit/chartConfigService.test.js b/__tests__/unit/chartConfigService.test.js
@@ -2,10 +2,17 @@ import ChartConfigService from 'c/chartConfigService';
 import { ATTRIBUTE_CARTESIAN_AXES } from 'c/constants';
 
 describe('c-chart-config-service', () => {
+  test(`Get new instance of default configuration`, () => {
+    const firstInstance = ChartConfigService.defaultConfiguration();
+    const secondInstance = ChartConfigService.defaultConfiguration();
+
+    expect(firstInstance).toStrictEqual(secondInstance); // Objects should have the same type and structure
+    expect(firstInstance).not.toBe(secondInstance); // Objects should not be a shallow copy but a new instance
+  });
   test(`Default configuration`, () => {
     const chartConfigService = new ChartConfigService();
     expect(chartConfigService.getConfig()).toEqual(
-      ChartConfigService.DEFAULT_CONFIGURATION
+      ChartConfigService.defaultConfiguration()
     );
   });
   test(`Update config with null option`, () => {
@@ -74,7 +81,7 @@ describe('c-chart-config-service', () => {
     chartConfigService.updateConfig(testSubject, ATTRIBUTE_CARTESIAN_AXES);
     chartConfigService.removeConfig(testSubject, ATTRIBUTE_CARTESIAN_AXES);
     expect(chartConfigService.getConfig()).toEqual(
-      ChartConfigService.DEFAULT_CONFIGURATION
+      ChartConfigService.defaultConfiguration()
     );
   });
   test(`Remove configuration`, () => {
@@ -83,14 +90,14 @@ describe('c-chart-config-service', () => {
     chartConfigService.updateConfig(testSubject, 'test');
     chartConfigService.removeConfig(testSubject, 'test');
     expect(chartConfigService.getConfig()).toEqual(
-      ChartConfigService.DEFAULT_CONFIGURATION
+      ChartConfigService.defaultConfiguration()
     );
   });
 
   test(`Clean basic object`, () => {
     expect(
-      ChartConfigService.cleanObject(ChartConfigService.DEFAULT_CONFIGURATION)
-    ).toEqual(ChartConfigService.DEFAULT_CONFIGURATION);
+      ChartConfigService.cleanObject(ChartConfigService.defaultConfiguration())
+    ).toEqual(ChartConfigService.defaultConfiguration());
   });
   test(`Clean object with array`, () => {
     const testSubject = { array: [10, 20, 30] };

diff --git a/force-app/main/default/lwc/chartConfigService/chartConfigService.js b/force-app/main/default/lwc/chartConfigService/chartConfigService.js
@@ -1,14 +1,16 @@
 import { ATTRIBUTE_CARTESIAN_AXES } from 'c/constants';
 
 export default class ChartConfigService {
-  static DEFAULT_CONFIGURATION = {
-    legend: {
-      display: false
-    }
-  };
+  static defaultConfiguration() {
+    return {
+      legend: {
+        display: false
+      }
+    };
+  }
 
   constructor() {
-    this._config = { ...ChartConfigService.DEFAULT_CONFIGURATION }; // clone default configuration
+    this._config = ChartConfigService.defaultConfiguration(); // clone default configuration
     this._scales = {
       xAxes: {},
       yAxes: {}