Skip to content

Commit

Permalink
chore: upgrade dependencies (#107)
Browse files Browse the repository at this point in the history
* build: upgrade dependencies

* build: upgrade source api version

* build: add localdevserver folder to gitignore

* build: add new LWS eslint plugin

* build: add eslint recommended rules

* build: upgrade PMD version

* build: update scratch org def settings

* build: upgrade LWS linter version
  • Loading branch information
victorgz authored May 17, 2022
1 parent 9d88349 commit c0df3d7
Show file tree
Hide file tree
Showing 50 changed files with 1,633 additions and 1,370 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ jobs:

# Install PMD
- name: Install PMD
run: wget https://github.com/pmd/pmd/releases/download/pmd_releases%2F6.22.0/pmd-bin-6.22.0.zip && unzip pmd-bin-6.22.0.zip
run: wget https://github.com/pmd/pmd/releases/download/pmd_releases%2F6.45.0/pmd-bin-6.45.0.zip && unzip pmd-bin-6.45.0.zip

# Execute PMD
- name: Execute PMD
run: pmd-bin-6.22.0/bin/run.sh pmd -minimumpriority 2 -d force-app -R apex-ruleset.xml -f text -l apex
run: pmd-bin-6.45.0/bin/run.sh pmd --minimum-priority 2 -d force-app -R apex-ruleset.xml -f text -l apex

scratch-org-test:
runs-on: ubuntu-latest
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,7 @@ tests/
_site/

# direnv
.envrc
.envrc

# SFDX Local Development Server
.localdevserver/
14 changes: 7 additions & 7 deletions apex-ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -257,20 +257,20 @@

<!-- Performance -->
<rule
ref="category/apex/performance.xml/AvoidDmlStatementsInLoops"
message="Avoid DML Statements inside loops"
ref="category/apex/performance.xml/AvoidDebugStatements"
message="Avoid debug statements"
>
<priority>1</priority>
</rule>
<rule
ref="category/apex/performance.xml/AvoidSoqlInLoops"
message="Avoid Soql queries inside loops"
ref="category/apex/performance.xml/EagerlyLoadedDescribeSObjectResult"
message="DescribeSObjectResult could have been loaded eagerly via SObjectType.getDescribe()"
>
<priority>1</priority>
<priority>4</priority>
</rule>
<rule
ref="category/apex/performance.xml/AvoidSoslInLoops"
message="Avoid Sosl queries inside loops"
ref="category/apex/performance.xml/OperationWithLimitsInLoop"
message="Avoid operations with limits inside loops"
>
<priority>1</priority>
</rule>
Expand Down
4 changes: 2 additions & 2 deletions config/project-scratch-def.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"language": "en_US",
"features": ["Communities"],
"settings": {
"orgPreferenceSettings": {
"networksEnabled": true
"communitiesSettings": {
"enableNetworksEnabled": true
}
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
6 changes: 5 additions & 1 deletion force-app/main/default/lwc/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
{
"extends": ["@salesforce/eslint-config-lwc/recommended"]
"extends": [
"eslint:recommended",
"@salesforce/eslint-config-lwc/recommended",
"@locker/eslint-config-locker/recommended"
]
}
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/animation/animation.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/baseAxis/baseAxis.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/chart/chart.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns="http://soap.sforce.com/2006/04/metadata"
fqn="timeline"
>
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
<masterLabel>LWCC App Builder</masterLabel>
<description
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/constants/constants.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/data/data.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/dataset/dataset.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/layout/layout.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/legend/legend.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/nanoid/nanoid.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/title/title.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/tooltip/tooltip.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
</LightningComponentBundle>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/utils/utils.js-meta.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>false</isExposed>
</LightningComponentBundle>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" ?>
<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<status>Active</status>
</ApexClass>
6 changes: 5 additions & 1 deletion force-app/sample/default/lwc/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
{
"extends": ["@salesforce/eslint-config-lwc/recommended"]
"extends": [
"eslint:recommended",
"@salesforce/eslint-config-lwc/recommended",
"@locker/eslint-config-locker/recommended"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe('c-sample-app-item', () => {
return Promise.resolve()
.then(() => {
const buttons = [
// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
...element.shadowRoot.querySelectorAll(
'button.slds-button.slds-button_neutral'
)
Expand All @@ -25,6 +26,7 @@ describe('c-sample-app-item', () => {
.then(() => {
// Verify that property is correctly incremented.
expect(
// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
element.shadowRoot.querySelector('c-sample-app-item')
).not.toBeNull();
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
<apiVersion>51.0</apiVersion>
<apiVersion>54.0</apiVersion>
<isExposed>true</isExposed>
<masterLabel>LWCC Chart Samples</masterLabel>
<description>See different examples of charts using LWCC</description>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ describe('c-sample-app-item', () => {
});
document.body.appendChild(element);

// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
const openModal = element.shadowRoot.querySelector(
'p.slds-card__footer-action.slds-text-link'
);
Expand All @@ -19,15 +20,18 @@ describe('c-sample-app-item', () => {
return Promise.resolve()
.then(() => {
// Verify that property is correctly incremented.
// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
expect(element.shadowRoot.querySelector('section')).not.toBeNull();

// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
const closeModal = element.shadowRoot.querySelector(
'button.slds-button.slds-button_neutral'
);
closeModal.click();
})
.then(() => {
// Verify that property is correctly incremented.
// eslint-disable-next-line @locker/locker/distorted-element-shadow-root-getter
expect(element.shadowRoot.querySelector('section')).toBeNull();
});
});
Expand Down
Loading

0 comments on commit c0df3d7

Please sign in to comment.