Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASS keyword false positive fix #449

Merged
merged 5 commits into from
Nov 1, 2023
Merged

PASS keyword false positive fix #449

merged 5 commits into from
Nov 1, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 1, 2023

Description

Please include a summary of the change and which is fixed.

  • Add fix for PASS keyword from many FP cases

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review November 1, 2023 10:44
@babenek babenek requested a review from a team as a code owner November 1, 2023 10:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a838cf) 90.82% compared to head (3639ad6) 90.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files         126      126           
  Lines        4209     4209           
  Branches      666      666           
=======================================
  Hits         3823     3823           
  Misses        251      251           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csh519
Copy link
Collaborator

csh519 commented Nov 1, 2023

Does it only for reducing 1 FP case?
Or did you intended to reduce FPs of internal cases?

@babenek
Copy link
Contributor Author

babenek commented Nov 1, 2023

@csh519
Yes, the fix is proposed after internal FP case. One benchmark FP was likely removed too.

Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reduce FP of Password rule.

LGTM 👍

@iuriimet iuriimet self-requested a review November 1, 2023 11:22
@babenek babenek merged commit 105e296 into Samsung:main Nov 1, 2023
29 checks passed
@babenek babenek deleted the kwpassfp branch November 1, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants