-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #453
Merged
Merged
Bugfix #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 90.89% 90.95% +0.06%
==========================================
Files 128 128
Lines 4283 4292 +9
Branches 678 679 +1
==========================================
+ Hits 3893 3904 +11
+ Misses 254 253 -1
+ Partials 136 135 -1
☔ View full report in Codecov by Sentry. |
csh519
reviewed
Nov 13, 2023
Co-authored-by: ShinHyung Choi <[email protected]>
babenek
requested review from
csh519,
xDizzix,
Yullia,
iuriimet,
meanrin and
Dmitriy-NK
November 13, 2023 06:19
csh519
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Value finding bug has been resolved.
LGTM 👍
iuriimet
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
value
,value_start
, andvalue_end
in Scan Results #452How has this been tested?
Please describe the tests that you ran to verify your changes.