Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #453

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Bugfix #453

merged 7 commits into from
Nov 13, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Nov 12, 2023

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea2ee96) 90.89% compared to head (450c964) 90.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   90.89%   90.95%   +0.06%     
==========================================
  Files         128      128              
  Lines        4283     4292       +9     
  Branches      678      679       +1     
==========================================
+ Hits         3893     3904      +11     
+ Misses        254      253       -1     
+ Partials      136      135       -1     
Files Coverage Δ
credsweeper/credentials/line_data.py 94.44% <100.00%> (+2.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review November 12, 2023 17:02
@babenek babenek requested a review from a team as a code owner November 12, 2023 17:02
@babenek babenek marked this pull request as draft November 12, 2023 20:22
@babenek babenek marked this pull request as ready for review November 12, 2023 20:36
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value finding bug has been resolved.

LGTM 👍

@babenek babenek merged commit f66408d into Samsung:main Nov 13, 2023
29 checks passed
@babenek babenek deleted the bugfix branch November 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in value, value_start, and value_end in Scan Results
4 participants