-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate function for future reusing #470
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 90.83% 90.81% -0.03%
==========================================
Files 123 124 +1
Lines 4169 4202 +33
Branches 658 663 +5
==========================================
+ Hits 3787 3816 +29
- Misses 252 254 +2
- Partials 130 132 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You always use (..., padding_safe=True, urlsafe_detect=True)
There is no need for code with False values of these parameters
I intend to use the function in PEM decoder https://github.com/Samsung/CredSweeper/pull/456/files#diff-9ebaed290816b8f8b45e2c2b198282a65c6fbc6b0584c0d0b5d55d3be88979a3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Co-authored-by: Kostiantyn Melnik <[email protected]>
Thank you for review. The issue was fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decode_base64()
method has been extracted from ValueBase64DataCheck
filter.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.