Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaped pattern discovering #629

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Escaped pattern discovering #629

merged 12 commits into from
Dec 12, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 7, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add escaped sequencec as left barrier of patterns
  • Fix FP in IP_ID_PASSWORD_TRIPLE
  • Update ValueBase64PartCheck to skip many FP (info level rules)

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek changed the title Esc Escaped pattern discovering Dec 11, 2024
@babenek babenek marked this pull request as ready for review December 11, 2024 06:24
@babenek babenek requested a review from a team as a code owner December 11, 2024 06:24
@Samsung Samsung deleted a comment from codecov-commenter Dec 11, 2024
Yullia
Yullia previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek requested a review from Yullia December 11, 2024 11:51
Yullia
Yullia previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

xDizzix
xDizzix requested changes Dec 12, 2024
View reviewed changes
credsweeper/filters/value_base64_part_check.py Outdated Show resolved Hide resolved
credsweeper/filters/value_entropy_base64_check.py Outdated Show resolved Hide resolved
@babenek babenek requested a review from Yullia December 12, 2024 08:14
@babenek babenek requested a review from xDizzix December 12, 2024 08:14
Yullia
Yullia approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 7838888 into Samsung:main Dec 12, 2024
32 checks passed
@babenek babenek deleted the esc branch December 12, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @xDizzix @Yullia