fix xlsx report for diff #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csh519
reviewed
Dec 23, 2024
credsweeper/__main__.py
Outdated
Comment on lines
276
to
284
| json_filename: Optional[str] = None, | ||
| xlsx_filename: Optional[str] = None) -> int: | ||
| """Scan content_provider data, print results or save them to json_filename is not None | ||
|
|
||
| Args: | ||
| args: arguments of the application | ||
| content_provider: FilesProvider instance to scan data from | ||
| json_filename: json type report file path or None | ||
| xlsx_filename: xlsx type report file path or None | ||
| json_filename: (Deprecated) json type report file path or None | ||
| xlsx_filename: (Deprecated) xlsx type report file path or None |
There was a problem hiding this comment.
It seems json_filename and xlsx_filename can be removed from scan()..
Could you please consider to remove those two parameters?
csh519
reviewed
Dec 23, 2024
credsweeper/__main__.py
Outdated
| @@ -270,20 +271,30 @@ def get_json_filenames(json_filename: str): | |||
| return added_json_filename, deleted_json_filename | |||
There was a problem hiding this comment.
It seems there get_json_filenames() doesn't seem to be used anywhere..
Could you please remove this function?
csh519
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
.addedinstead name ends_addedfor JSON diff reportsHow has this been tested?
Please describe the tests that you ran to verify your changes.