[vconone] Notice people to update year #14588
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayo09
force-pushed
the
0123-vconone-update
branch
from
5e84e6c to
1ba8653
Compare
dayo09
commented
Jan 23, 2025
| @@ -45,5 +61,14 @@ TEST(vconone, copyright) | |||
| { | |||
| auto str = vconone::get_copyright(); | |||
|
|
|||
| int year = 2024; | |||
|
|
|||
| if (year < get_current_year()){ | |||
There was a problem hiding this comment.
Should it fail the test? I am worried that production CI fails from this small problem.
There was a problem hiding this comment.
Or, what if, we make CI fail if it's not updated until Feburary of each year.
There was a problem hiding this comment.
Currently, printing warning is almost nothing because it's not printed unless verbose keyword is on for ./nncc test
But I am not sure this can work. ONE-DCO-Signed-off-by: Dayoung Lee <[email protected]>
dayo09
force-pushed
the
0123-vconone-update
branch
from
1ba8653 to
3b19e64
Compare
|
@dayo09 , maybe post an issue to get opinions from others. |
dayo09
commented
Jan 24, 2025
| @@ -45,5 +62,15 @@ TEST(vconone, copyright) | |||
| { | |||
| auto str = vconone::get_copyright(); | |||
|
|
|||
| int year = 2024; | |||
There was a problem hiding this comment.
TODO: Get this year properly from get_copyright function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But I am not sure this can work.
ONE-DCO-Signed-off-by: Dayoung Lee [email protected]