[infra/cmd] Update format command #14601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanshpark
reviewed
Feb 3, 2025
Comment on lines
-127
to
-128
| # Manually ignore style checking | ||
| FILES_TO_CHECK_CPP=`echo "$FILES_TO_CHECK_CPP" | egrep -v '((/NeuralNetworks\.h)|(/NeuralNetworksExtensions\.h))$'` |
There was a problem hiding this comment.
Q) are these related with .FORMATDENY ? or another format update ? (I assume we don't need to check these NeuralNetworks files)
There was a problem hiding this comment.
They are ignored by compiler/ann-api/include/.clang-format and tests/nnapi/bridge/include/.clang-format. I'll update commit comment.
This commit updates format command to skip C/C++ format checking by .clang-format in each directory, It will not use .FORMATDENY file and manual setting in script any more. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
update_format_checker
branch
from
35288e0 to
c6fb71a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates format command to skip C/C++ format checking by .clang-format in each directory,
It will not use .FORMATDENY file and manual setting in script any more.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]
Draft: #14556