add onnx-subgraph full changes code to Samsung ONE/tools #14613
Conversation
|
I get
error when I pull this branch. Maybe rebase to master may fix this problem? |
| git clone https://github.com/ekg/glia.git | ||
| cp -r glia/json ../include | ||
| cp glia/json-forwards.h ../include | ||
| cp glia/jsoncpp.cpp ../src/lib |
There was a problem hiding this comment.
copy files will be listed as unchanged files in git status.
plz do not copy files like this.
I cannot find where jsoncpp.cpp file is used.
tools/onnx-subgraph/CMakeLists.txt
Outdated
|
|
||
|
|
There was a problem hiding this comment.
and also to all other codes that have unnecessary double lines
| target_link_libraries(onnx-subgraph onnx-subgraph-parser ${Python3_LIBRARIES}) | ||
|
|
||
|
|
||
| set(ONNX_SUGRAPH_FILES |
There was a problem hiding this comment.
| set(ONNX_SUGRAPH_FILES | |
| set(ONNX_SUGRAPH_FILES |
tools/onnx-subgraph/Readme.md
Outdated
| ## Pre-steps | ||
| ### Download the test AI models | ||
| 1. bash scripts/test_model_download.sh, then "resnet-test.onnx" will be got in ./build | ||
| 2. you can change to any other onnx files as your needs, or edit the download link in "scripts/test_model_download.sh" |
There was a problem hiding this comment.
if this line exceeds 100 cols, please split so that will be within 100 cols.
plz apply to all other codes
tools/onnx-subgraph/include/device.h
Outdated
| #include "json.h" | ||
| enum class DeviceType |
There was a problem hiding this comment.
| #include "json.h" | |
| enum class DeviceType | |
| #include "json.h" | |
| enum class DeviceType |
please add some empty lines between codes, like here and between methods/functions
so that reading is better.
too tight codes are hard to read.
plz apply to all other codes.
|
I've left some comments with rought review with formats. |
ok, I will split it to small PRs, thanks for your review |
|
close this PR, and split to small PRs |
|
@chenyx113 , it would be better to leave this PR open. |
|
When the initial CMakeLists.txt file is landed, I'll enable a Workflow to check build and test. |
ok，I will prepare as suggestion, thank you |
PR with full changes of onnx-subgraph tool.
related issue of: #14534
historical draft PR:
#14593
#14563
we 'd like our code to be an individual tool in ONE/tools path.
./nnas format & ./nnfw copyright-check have been run successfully locally.
please help review, any suggestions and comments will be appreciated, thank you!
ONE-DCO-1.0-Signed-off-by: Youxin Chen [email protected]