Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[circle-mlir] Fix Dockerfile #14628

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[circle-mlir] Fix Dockerfile #14628

merged 2 commits into from
Feb 11, 2025

Conversation

shs-park
Copy link
Contributor

@shs-park shs-park commented Feb 10, 2025 •
edited
Loading

This will fix installing clang-format-16.
To install this format, the LLVM repository must be set up in advance.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park [email protected]

for #14627, #14607

@shs-park
[circle-mlir] Fix Dockerfile
5d8feba 
This will fix installing `clang-format-16`.
To install this format, the LLVM repository must be set up in advance.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <[email protected]>
@shs-park shs-park self-assigned this Feb 10, 2025
@shs-park shs-park requested a review from a team February 10, 2025 11:46
@shs-park shs-park mentioned this pull request Feb 10, 2025
Open
3 tasks
@seanshpark
Copy link
Contributor

@shs-park , thanks for the check :)

clang-format is used in format check in another Workflow, so as CI Docker image, we don't need this.
installation here is to assist when used as client side build environment.
tmux tree are also for this purpose.

Your change is nice solution but I need to think more about adding clang-format tool...

@seanshpark
Copy link
Contributor

I think it is OK to land this change :)

@shs-park @seanshpark
Update circle-mlir/infra/docker/u2204/Dockerfile
9423178 
Revise to make a single run

Co-authored-by: SaeHie Park <[email protected]>
@shs-park shs-park requested a review from seanshpark February 11, 2025 04:27
seanshpark
seanshpark approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@seanshpark seanshpark merged commit 054a0bc into Samsung:master Feb 11, 2025
3 checks passed
@shs-park shs-park deleted the circle-mlir/fix-docker-clang branch February 11, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark seanshpark approved these changes

Assignees

@shs-park shs-park

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shs-park @seanshpark