Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle-mlir] Introduce CMake test option flags #14634

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

seanshpark
Copy link
Contributor

This will introduce CMake configure option flags

  • ENABLE_TEST to enable/disable test
  • ENABLE_COVERAGE to enable/disable test coverage

This will introduce CMake configure option flags
- ENABLE_TEST to enable/disable test
- ENABLE_COVERAGE to enable/disable test coverage

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team February 11, 2025 06:06
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo found..
😅

circle-mlir/infra/cmake/CfgOptionFlags.cmake Outdated Show resolved Hide resolved
Co-authored-by: Seungho Henry Park <[email protected]>
@seanshpark seanshpark requested a review from shs-park February 11, 2025 06:36
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit 5b7d5e3 into Samsung:master Feb 11, 2025
5 checks passed
@seanshpark seanshpark deleted the cm_cmake_opt branch February 11, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants