-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Reinforce sample app for window #5669
Closed
sparrow74
wants to merge
82
commits into
Samsung:DevelNUI
from
sparrow74:ReinforceSampleAppForWindow
Closed
[NUI] Reinforce sample app for window #5669
sparrow74
wants to merge
82
commits into
Samsung:DevelNUI
from
sparrow74:ReinforceSampleAppForWindow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sparrow74
commented
Oct 30, 2023
Window는 기능 자체가 Display server, App FW, Sensor FW 등 다른 모듈과의 연동이 많은 관계로
Unit Test가 아닌 Manual Test로 진행해서 확인해야 하는 경우가 많습니다.
따라서, 별도의 Unit Test가 있지만, 기존의 manual test의 테스트 항목을 확대하고 강화 해야 할 필요가 있습니다.
추가된 Test Case는 Window CSharp binder의 Code Clean up 및 refactoring에 대한 검증 차원도 포함됩니다.
Window.cs에 있는 Function과 Property Test Case를 추가하거나 강화하였습니다.
이번에 새로 추가된 Test에 대한 Function 들입니다.
SetClass, Raise, Lower, Activate, Show, Hide, Avaiaible Rotation 관련 Functions,
Prefered Oritataion 관련 Functions, SetFocus, SetOpaueState,
Window Type 및 Notification Level, Screen On/Off, Brightness, Window Size/Position, PartialUpdate,
Unit Test로 확인할 수 없는 부분들을 Menual Test를 통해 확인하기 위함입니다.
Manual Test에 테스트 항목을 추가하여 개발자로 하여금 직접 확인하고자 하였습니다.
다른 Phase로 Signal/Event 관련 Test 항목을 추가하고자 합니다.
Signed-off-by: Suyeon Hwang <[email protected]>
Since GetLastTouchEvent returns all values regardless of touch or hover, it was separated into GetLastTouchEvent and GetLastHoverEvent. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/298755/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/298753/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/298752/
ParticleSystem provides 4 classes: ParticleEmitter - emitter of particles ParticleSource - source of particles (spawning new particles) ParticleModifier - controller of particles behaviour Particle - wrapper over particle data
Adds Tizen.NUI.Physics2D.PhysicsAdaptor, Tizen.NUI.Physics2D.PhysicsActor and Tizen.NUI.Physics2D.ScopedAccessor classes. These wrap the DALi physics classes in dali-toolkit; which run the physics integration thread in the Update thread (using the FrameCallback natively). They offer basic APIs for attaching Views to Chipmunk.Body physics objects, so that they can be rendered.
Visual look at same value, Visual.MixColor's alpha and Visual.Opacity, we need to synchronize both values. Since we don't open Visual.Opacity property for View side let we control this value inside of View. Signed-off-by: Eunki, Hong <[email protected]>
To support using new feedback_pattern for da profile, new pattern string and id value is added to Pattern dictionary. Signed-off-by: Yunhee Seo <[email protected]>
…ck type Allows feedback stop according to feedback type. This is newly added to System.Feedback. - public void StopTypeInternal(FeedbackType type) -> It stops current feedback playing according to feedback type. Signed-off-by: Yunhee Seo <[email protected]>
…k patterns To support general feedback patterns, newly patterns are added. With these string pattern, it is possible to use mapped feedback patterns from libfeedback. Signed-off-by: Yunhee Seo <[email protected]>
Signed-off-by: Seoyeon Kim <[email protected]>
Fix unmatched function binding Signed-off-by: Eunki, Hong <[email protected]>
Add new request of KVM Service as below: - ReceiveDragData: Request to get current drag data. - CancelDrag: Request to cancel current drag.
Window window = NUIApplication.GetDefaultWindow(); window.HoverEvent += OnHover; private void OnHover(object source, Window.HoverEventArgs e) { // e.Hover.GetState(0); // PointStateType.Motion; }
These determine whether to send touch and hover motion events or not. This is used when the user does not want to receive motion events.
widget need to keep it's instance
Signed-off-by: seungho baek <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Since we always try to register to Registry for Gradient case, there can make some error for Shape use case. Signed-off-by: Eunki, Hong <[email protected]>
This is one of the oldest interops and was actually problematic for multiple reasons; the return type didn't match and the third parameter was expected to have exactly the same value in every invocation. While fixing these issues, parsing the status string was moved from C++ to C# for readability. Co-authored-by: Artur Świgoń <[email protected]>
- Add comment for public API - Remove some unused private value/method Signed-off-by: Eunki Hong <[email protected]>
After patch #5595 merged, there was some hidden bugs occured. This PR is one of portential bug fix. Signed-off-by: Eunki, Hong <[email protected]>
Previously, we can only add the root view of FrameUpdateCallback as root layer of window. Now let we add some API that user can set specific view for given FrameUpdateCallback will use. This API will be used when we want to optimize callback behaviour. Signed-off-by: Eunki, Hong <[email protected]>
Implement Flush action. It will be used when user want to ensure the Lottie property changed applied sequencly. Signed-off-by: Eunki, Hong <[email protected]>
Since View constructor automatically change 'PositionUsesPivotPoint' value as false, some logic might changed when we Register ModelNode newly. Signed-off-by: Eunki, Hong <[email protected]>
Since C# initialize static values when that namespace / class access first time, We need to access some static values at static Preload() timing. Signed-off-by: Eunki, Hong <[email protected]>
To support set/get full screen sized window. The full screen sized window means the window is resized with screen size. In addition, this window is the z-order is the highest.
We implement View.Preload() API now. So compiler can feel dizzy which one is Control.Preload() should do. To avoid this compilation warning, let we add 'new' keyword for it. Signed-off-by: Eunki Hong <[email protected]>
Let we remove useless error message + Make getter return valid setting value for View.TooltipText property. Signed-off-by: Eunki, Hong <[email protected]>
Let we minimize the net core dependency Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Eunki, Hong <[email protected]>
ReInforce window samples to verify window's functions
sparrow74
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor,
hinohie and
wonrst
as code owners
October 30, 2023 02:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.