[NUI] Remove basehandle usage at Accessibility static #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
|
@Seoyeon2Kim @lol-github @aswigon @m-bialota |
aswigon
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM. I've just checked that GetInstanceSafely<T> only requires T to be a subclass of BaseHandle, but its parameter can simply be object, so there should be no semantic change with this patch.
public static T GetInstanceSafely<T>(this object wrapper, IntPtr cPtr) where T : BaseHandle
dongsug-song
force-pushed
the
DevelNUI
branch
from
b77fce5 to
b422c07
Compare
|
The TizenFX master branch has been changed for API12(tizen_9.0). |
Since we try to resolve some unusual behavior of BaseHandle, the dummyHandle in Accessibility can give us some confuse logs. Actually, we don't need to hold it as BaseHandle type. we only need this as object type. So, let we make it as object, instead of BaseHandle. Signed-off-by: Eunki, Hong <[email protected]>
hinohie
force-pushed
the
accessible_static_object
branch
from
f494fc3 to
40538ce
Compare
|
Hard reset done :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we try to resolve some unusual behavior of BaseHandle, the dummyHandle in Accessibility can give us some confuse logs.
Actually, we don't need to hold it as BaseHandle type. we only need this as object type. So, let we make it as object, instead of BaseHandle.