[NUI] Add AliveCount property to get currently alived View number #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsug-song
requested review from
hyunjushin,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
hinohie
reviewed
Nov 14, 2023
| @@ -403,6 +403,7 @@ protected override void Dispose(bool disposing) | |||
| { | |||
| // at this case, implicit nor explicit dispose is not required. No native object is made. | |||
| disposed = true; | |||
| aliveCount--; | |||
There was a problem hiding this comment.
Wow.. A lots of people will miss this cases! Looks good to me
hinohie
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Add AliveCount property to get currently living View number
API Changes
none