[NUI] Remove old frame range if we set marker + Minor fix up when marker invalid #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker invalid LottieAnimationView cache both frame range as int, and marker. But two API set same property - PlayRange. So if some code like below thing was not working well ``` // Let "marker" frame range is 10~20 lottieView.SetMinMaxFrame(30, 40); // play range become 30~40 lottieView.SetMinMaxFrameByMarker(marker); // play range become 10~20 lottieView.SetMinMaxFrame(30, 40); // play range need to be 30~40 again, but it didn't due to the cache. ``` To avoid like above case, let we clean cache explicit parameter. Also, Let we add some more error check if app use invalid marker (Lottie file not loaded, or marker is invalid.) In this case, let we just follow minMaxSetTypes.NotSetByUser logic then. Signed-off-by: Eunki Hong <[email protected]>
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LottieAnimationView cache both frame range as int, and marker. But two API set same property - PlayRange.
So if some code like below thing was not working well
To avoid like above case, let we clean cache explicit parameter.
Also, Let we add some more error check if app use invalid marker (Lottie file not loaded, or marker is invalid.)
In this case, let we just follow minMaxSetTypes.NotSetByUser logic then.