Bugfix/ai avatar #6591
Open
Bugfix/ai avatar #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 20, 2025 13:13
- RestClient now implements IDisposable and disposes the HttpClient instance. - ServiceClientManager now properly disposes all RestClient instances. - Added Dispose pattern to RestClient to ensure HttpClient is disposed correctly. - Updated ServiceClientManager to use using statement or call Dispose method to release resources. WID:9875283
- Analyzed the root cause of NullReferenceException and modified the code to check for null objects and perform appropriate actions. - Improved exception handling by catching more specific exception types instead of NullReferenceException, making the exception handling clearer and allowing separate handling for specific exception types. - Applied defensive programming to validate input parameters and check for null objects to prevent NullReferenceException from occurring. WID:9861897
AnglerLee
requested review from
dongsug-song,
Seoyeon2Kim,
taehyub,
hinohie,
hyunjushin and
jaehyun0cho
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.AIAvatar.RestClient::Dispose(System.Boolean)
|
hinohie
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
API Changes