Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add size, position getter/setter for UIVector2 type #6615

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[NUI] Add size, position getter/setter for UIVector2 type #6615

merged 1 commit into from
Feb 4, 2025

Conversation

rabbitfor
Copy link
Collaborator

Description of Change

Add API to set/get size and position with UIVector2 type.

view2.Size(view1.Size());
view2.Position(view1.Position());

API Changes

  • ACR:

@rabbitfor rabbitfor changed the title [NUI] Add size, position setter for UIVector2 type [NUI] Add size, position getter/setter for UIVector2 type Feb 3, 2025
jaehyun0cho
jaehyun0cho approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

everLEEst
everLEEst approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rabbitfor rabbitfor merged commit cb1a765 into Samsung:DevelNUI Feb 4, 2025
2 of 3 checks passed
@rabbitfor rabbitfor deleted the size branch February 4, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaehyun0cho jaehyun0cho jaehyun0cho approved these changes

@everLEEst everLEEst everLEEst approved these changes

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabbitfor @jaehyun0cho @everLEEst