Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add a welcome screen that generates random quotes #268

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

njouud
Copy link
Contributor

@njouud njouud commented Dec 11, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added a new splash screen that shows after the initial splash screen. The new splash screen shows the app logo and a randomly generated quote to motivate and uplift the user.

  1. Added a new file lib/core/pages/welcome_page.dart:
  • creates a new page to be rendered after initial splash screen, then navigates to homepage lib/core/pages/home_page.dart
  • contains function getQuote() to generate a random quote
  1. Edited lib/app/view/app.dart:
  • replaced routing to home_page.dart with routing to welcome_page.dart (MaterialPageRoute(builder: (_) => const WelcomePage()))
  1. Edited lib/app/routes/routes.dart:
  • routes to welcome_page.dart first before home_page.dart (if (settings.name == WelcomePage.route)...)

Featured Covered in this PR

  • Add a welcome screen (a second splash screen after the already-existing first one) that renders a random quote

Related Tickets & Documents

Screenshots, Recordings

New page screenshot:
screenshot
Recording:
https://github.com/user-attachments/assets/2b153443-8ad7-44f1-a805-be956d201801

Tested Feature??

  • In Real Device.
  • In Emulator

Procos12 and others added 13 commits November 25, 2024 18:05
…cting notes.

Added baseline code for implementing the pop-up to select whether or not you would like a PDF or text file.
Edits in file: lib/core/widgets/home_page_app_bar.dart
Can be found using search for: @Procos12.
…mber of notes selected.

Purely cosmetic change, looks better this way.
Added an Export Icon when Selecting Notes
Placeholder functions were written into the code instead of a comment.
Refer to lines 575 and 587 in lib/core/widgets/home_page_app_bar.dart
Cannot get the logo to be rendered for some reason.
The issue with the logo is in lib/core/pages/welcome_page.dart
[feature] Add a welcome screen that generates random quotes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@njouud
Copy link
Contributor Author

njouud commented Dec 11, 2024

Hi @SankethBK, please let me know whether this PR is sufficient to fulfill the request to merge! I just want to add that my team and I worked on this repository as part of our Software Engineering course at Carnegie Mellon University (our deadline to continue contributing is by December 14th), thanks for your constant communication with me so far.

Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I have made some minor changes

@SankethBK SankethBK merged commit a5c756e into SankethBK:master Dec 12, 2024
3 checks passed
SankethBK pushed a commit that referenced this pull request Dec 12, 2024
@njouud
Copy link
Contributor Author

njouud commented Dec 12, 2024

Thanks for allowing us to contribute! We learned a lot working with this codebase :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] material you theme
4 participants