Fixed boxes_from_mask avoiding tiny boxes #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to avoid the situation where the threshold or the mask have tiny dots or tiny contours (I had instances with some images where there are 200 or more boxes found but only 1 was relevant). This is mostly due to jpeg compression artefacts on the mask or other issues related to the mask (usually not present when drawing the mask directly through the web app).
This makes the algorithm really slow because it has to compute inpainting a lot of times for tiny boxes and doesn't provide a good result.
I am using the contour area as a discriminant.