Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading icon on Netlify status #64

Open
orestes opened this issue May 11, 2022 · 4 comments
Open

Misleading icon on Netlify status #64

orestes opened this issue May 11, 2022 · 4 comments

Comments

@orestes
Copy link

orestes commented May 11, 2022

Love the project!

Ran into a small issue yesterday.

This is the status of the last builds for my project on Netlify:

image

However, the icon shows an "error" icon:

image

I would expect the icon to reflect the "cancelled" status instead.

It would also be nice if there was a way to preserve the last non-cancelled status instead of scaring me :)

Keep up the good work!

@SantiMA10
Copy link
Owner

Any design proposals? 😇

@orestes
Copy link
Author

orestes commented May 25, 2022

I would keep the last non-cancelled status, like I proposed above. After all, the cancelled job did not create any side effects and that last status is still accurate.

I would imagine that's a bit problematic since you can't just check the last job, but the last n jobs instead until you find one that's not cancelled. If that's something that should be avoided, maybe use an empty gray icon, or even one with a question mark.

@SantiMA10
Copy link
Owner

Ups! I misunderstand your initial comment 🤦

I made a quick check and that behavior you describe is the one it should have unless the Netlify API is considering the canceled status an error (code here) 🤔

@SantiMA10
Copy link
Owner

If you want to debug what is happening and provide a solution in a PR, here is the documentation on how to debug the StreamDeck application: https://developer.elgato.com/documentation/stream-deck/sdk/create-your-own-plugin/#debugging 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants