Add parametric equalizer and implement it for Arctis Nova 5 #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Added support for parametric equalizers.
Added implementation for Arctis Nova 5.
Description
I did not want to break the existing basic equalizer implementation so I added it independently as
I added YAML and JSON outputs, help texts, output of capabilities and the five filter types the Arctis Nova 5 supports for now.
More filter types can be added if other headsets feature different filters and the supported filters are set by each devices implementation.
I implemented the 10 band parametric equalizer for the Arctis Nova 5 and tested setting bands and the different filter types against the SteelSeries GG Windows software.
Bands are represented by the typical parameters of parametric equalizers: frequency, gain, q-factor (band width) and filter type.
This is the help text (which also gives an example of the format I chose to specify the bands):
This is the info the JSON (and YAML) output contains:
Headset Name
Arctis Nova 5
Checklist