Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "default stdin" behavior #349

Closed
wants to merge 1 commit into from
Closed

Conversation

valeriangalliat
Copy link
Member

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.23% when pulling a429d62 on no-default-stdin into 133057d on develop.

@pascalduez
Copy link
Member

Cloning comment from #348

I understand that if we ship the current state it won't be possible to reassign the behaviour or $ sassoc later. Removing the stdin feature feels also a bit of a pity at that stage.

Possible solution
Why not shipping 2.0 with no default behavior (print usage infos), and set the stdin to work with - ?
This way we will have more time to think of it and still have to ability to add a default behaviour later.

@valeriangalliat
Copy link
Member Author

Why not shipping 2.0 with no default behavior (print usage infos), and set the stdin to work with - ?

Agreed.

Though, - will not be a "special file" for <src>..., it will really be another way to use SassDoc (and it won't be integrated at all with <src>....

@pascalduez
Copy link
Member

Though, - will not be a "special file" for ..., it will really be another way to use SassDoc (and it won't be integrated at all with ....

Yes, definitely. It's really different.
That reminds me when implementing the stdin thing I suggested to trigger it with --stdin.

valeriangalliat added a commit that referenced this pull request Jan 30, 2015
@valeriangalliat valeriangalliat mentioned this pull request Jan 30, 2015
@valeriangalliat valeriangalliat deleted the no-default-stdin branch February 2, 2015 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants