-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to save page content with note #123
Conversation
pavka14
commented
Jan 10, 2025
•
edited
Loading
edited
- add option to also save the page content when adding a note
- additional option to search in the saved content and not only in notes
@pavka14 What is the use of "content" ? Why should be saved in the notes ? |
45a4f8c
to
d118ebf
Compare
Hi, I am still working on this. It is not finished. I thought I was pushing against my fork and was only going to submit to you when done, sorry about this. |
@pavka14 Ok, no problem 😄 Thanks for contributing to this project |
Basically, the idea is to be able to also extract the whole page text so you can search in that too, like if you later wonder "where did I read that text last year" - you will have it locally saved. I want to expand this a lot further and to integrate it with something else I am working on. I sent you a connect request on LinkedIn so we can chat about it there. |
- add option to also save the page content when adding a note - additional option to search in the saved content and not only in notes
d118ebf
to
8569330
Compare
@Sav22999 I think it's ready for testing and review now. Please keep in mind that I don't know any javascript, have never done anything in javascript, and all this was done using Copilot. So, if you see something stupid, probably it is stupid and not some clever hack. In short, the purpose of the change:
|
@@ -72,6 +72,7 @@ | |||
"permissions": [ | |||
"storage", | |||
"tabs", | |||
"<all_urls>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if the thing will work without this?
@pavka14 Thank you for your contribution. Because I am a bit busy in this period (til the end of the month, at least) I'll review the whole code in February... sorry for the delay |
@pavka14 Here I am! |
- Restyled in All notes - Moved from "General" to "Advanced"
@pavka14 Thank you for your contribution! I'm approving this PR, after I've improved the UI and checked the code 😄 Great work! |
Thanks. I'll message you on LinkedIn about my general idea. |