Remove removed_in version of role_arn #1399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the removed_in version of role_arn, iam_role and iam_role_session_duration, to give consumers more time to upgrade.
zaro0508
reviewed
Dec 28, 2023
| "iam_role", | ||
| "sceptre_role", | ||
| deprecated_in="4.0.0", | ||
| removed_in=None, |
There was a problem hiding this comment.
I assume that changing removed_in to None will relax the requirement to remove this item in the next major release?
What would be the message users see as a result of this change?
|
@alexharv074 PR #1406 has been merged so could you please do the same for |
|
Closing in favour of #1423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the removed_in version of role_arn, iam_role and iam_role_session_duration, to give consumers more time to upgrade.
related to #1406