Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #1484] Gracefully handle invalid parameters #1485

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

alex-harvey-z3q
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q commented Jul 5, 2024

This adds logic to _cast_parameters to also handle the case that the parameters dict itself is not a dict but some other invalid type.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

This adds logic to _cast_parameters to also handle the case that the
`parameters` dict itself is not a dict but some other invalid type.
@alex-harvey-z3q alex-harvey-z3q requested a review from zaro0508 July 5, 2024 06:33
@alex-harvey-z3q alex-harvey-z3q merged commit 3d315c3 into Sceptre:master Jul 6, 2024
11 checks passed
@alex-harvey-z3q alex-harvey-z3q deleted the ah/1484-bugfix branch July 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants