Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pageSnapping option #435

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fixed pageSnapping option #435

merged 5 commits into from
Apr 25, 2024

Conversation

LucazzP
Copy link
Contributor

@LucazzP LucazzP commented Sep 28, 2023

Since the package only can be published using only published packages, not git ones, this PR only could be merged after this another PR on the photo_view, that adds the pageSnapping parameter. bluefireteam/photo_view#542

If you need to use this fix, you can use my fork and help the PR adding a thumb up 👍 to both PRs :)

Fixes: #296 #332

@SergeShkurko SergeShkurko self-requested a review February 10, 2024 00:57
@LucazzP
Copy link
Contributor Author

LucazzP commented Apr 22, 2024

Hey guys, good news!!

The photo_view PR was approved and launched on the 0.15.0 version, so the PR is ready for the merge!

@SergeShkurko

@LucazzP LucazzP requested a review from SergeShkurko April 22, 2024 12:37
@SergeShkurko SergeShkurko merged commit d60cd4b into ScerIO:main Apr 25, 2024
1 check was pending
@SergeShkurko
Copy link
Member

@LucazzP thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdfx web - bouncing behaviour is quite annoying when scrolling
2 participants