Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: consistent style an dtext on datasets list page #1492

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Jun 6, 2024

Applied consistent style to search buttons in datasets list. Updated buttons text

Description

This PR applies consistent style and wording to the multiple form buttons present in the datasets list page.
datasets_list_buttons_pr

Motivation

The datasets list page (which is the main page where users spend most of their time) has inconsistent style and text on the multiple buttons present in the text search and filters form.

Fixes/Changes:

Please provide a list of the fixes/changes implemented in this PR

  • /datasets/dashboard/full-text-search-bar.component: changed html and scss code of the search and clear button
  • /datasets/datasets-filter: changed html and scss code of the search and clear button

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required] N/A
  • official documentation updated [nice-to-have] N/A

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

@Junjiequan
Copy link
Member

Junjiequan commented Jun 6, 2024

The Clear Text button clears the text and refreshes all the data. In contrast, Clear All Filters only empties the filter input fields without refetching data. It merely gives a false impression of a data refetch with the page reloading and the popup success text.
I don't know would it be a problem and do we need to fix it in this PR

@nitrosx
Copy link
Member Author

nitrosx commented Jun 6, 2024

Behavior of Clear Text button is now consistent with the behavior of Clear All Filters one.

@nitrosx nitrosx merged commit aa3648a into master Jun 7, 2024
6 checks passed
@nitrosx nitrosx deleted the fix_swap_4086_datasets_list_form branch June 7, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants