feat: Datafiles configurable actions #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…frontend into datafiles-actions
|
Examples of the new setup |
Junjiequan
reviewed
Jul 24, 2024
src/app/datasets/datafiles-actions/datafiles-action.component.ts
Outdated
Show resolved
Hide resolved
Junjiequan
approved these changes
Jul 25, 2024
nitrosx
changed the title
Junjiequan
reviewed
Jul 29, 2024
src/app/datasets/datafiles-actions/datafiles-action.component.spec.ts
Outdated
Show resolved
Hide resolved
Merged
4 tasks
bpedersen2
approved these changes
Jul 30, 2024
|
Junjiequan
changed the title
bpedersen2
reviewed
Aug 7, 2024
| } | ||
|
|
||
| //document.body.appendChild(form); | ||
| this.form.submit(); |
There was a problem hiding this comment.
This gives "Form submission canceled because the form is not connected".
Probably a race between click an submit, which causes the form to disappear prematurely.
I suggest to switch to using a POST request directly (with either form-data-encoding or even better a json-encoded data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding a configurable datafiles actions. Such actions can be configured through the config file and do not need any additional custom code. Actions can call any URL through a POST call and have a configurable label and icon.
This PR requires a change in the configuration for the FE as reported by the documentation. It also required an update of the BE as the FE configuration should be updated.
Motivation
Site admins have the need to configure and customize the datafiles actions to their IT infrastructure. For example, adding a button that produced a notebook ready to load the dataset and the selected files. This work is the first attempt to provide such functionality
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Official documentation is present in md format in the file docs/configuration/datafiles-actions.md of this repository.
Backend version