Improve reusability of github workflows #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I am not sure if this is the right place to ask or suggest this, but for the QuantumKitHub organization, I recently started using a workflow based on the SCIML ones in my github actions. Really, I just wanted to have the exact same workflow for the tests.
I was hoping to just use the actions defined here, however that fails because the secrets have been defined implicitly, and the packages use the
secrets: inheritsetting to pass them on. This however only works for actions that are defined within the same organization.While I was able to circumvent this issue by simply copy-pasting the actions into my own organization, there might be other people that want to have a similar setup. I did some digging, and from what I understand, if you explicitly declare the secrets that will be passed on, this works across organizations.
This PR features the exact changes I made to enable this. I find it a bit hard to add tests, but I have a PR that now uses this workflow without failing because of the secrets here.