Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deficiency one and concnetration robustness #964
Deficiency one and concnetration robustness #964
Changes from 22 commits
8b26cb7
ad5d765
d9635fc
db8c410
414c7c5
a3521d2
80839b4
d429a8c
5eb54c7
9b77f7d
75f2ed5
7bb7215
dfa3c57
4700366
78ad647
a89d091
a66496d
83228b3
c5914c7
2dfb133
b1774d0
afbfc94
29f6dd2
9dce9ed
75fd1af
c1c8db4
19309dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column difference could be stored in a pre-calculated vector from outside the loop like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More generally, seems like this could be written as a non-allocating loop that bails if a second match is found instead of continuing the search, and if a second match isn't found saves it in
robust_species
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re the first comment: would I accomplish the same thing by adding
@views
in thesupp
line, so it becomesSeems like allocating it entirely outside might take a lot of space (would have to be a 3D array, where each difference vector is indexed by (c_s, c_p))
For the second comment, what do you mean by second match? I don't immediately see a way to skip a check for a species we already know is robust because we can't know that it's in the support of a difference of two complexes until we calculate it