output extra information from linearization #3429
Open
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If this is to aid in debugging initialization, then #3418 addresses exactly this issue, and would apply here as well.
| x = u, | ||
| p, | ||
| t, | ||
| success) |
There was a problem hiding this comment.
Isn't returning success unnecessary? If !success then we error, so at this point success is guaranteed to be true.
There was a problem hiding this comment.
should this be a ReturnCode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also change the use of the symbol
uin docstrings and warning messages for the more explicitunknownsto not confuse users of input-output functions, whereuis traditionally (also in our docs) used to denote input rather than state.