Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix several tests #368

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AayushSabharwal
Copy link
Member

No description provided.

@matthew-kapp
Copy link
Contributor

@AayushSabharwal I'm trying to learn here. How does the number of tests passed go from 539 to 572?

Before:

Test Summary: | Pass Fail Error Broken Total Time
Core | 539 3 1 2 545 14m47.0s
Blocks: utils | 14 14 56.4s
Blocks: math | 93 93 1m25.1s
Blocks: nonlinear | 15 15 16.3s
Blocks: continuous | 76 76 1m37.4s
Blocks: sources | 63 63 3m28.0s
Blocks: analysis points | 28 1 29 29.7s
Analog Circuits | 81 2 83 2m16.5s
sensors | 4 4 5.8s
voltage divider with a short branch | 6 6 10.8s
RC | 2 2 3.2s
RL | 2 2 3.1s
RC with voltage sources | 12 12 25.7s
RC with current sources | 2 2 1.2s
Integrator | 3 3 5.8s
Voltage function generators | 21 21 14.3s
Current function generators | 21 21 11.1s
Diode component test | 1 1 2 10.0s
HeatingDiode component test | 3 1 4 19.1s
VariableResistor with Temperature Dependency | 4 4 12.7s
Digital Circuits | 34 34 1.1s
Chua Circuit Demo | 1 1 7.0s
Thermal Circuits | 17 17 17.0s
Thermal Demo | 10 10 24.1s
Magnetic | 3 3 5.0s
Mechanical Rotation | 31 31 58.4s
Mechanical Translation | 16 16 51.2s
Mechanical Translation Modelica | 7 7 14.9s
Multi-Domain | 16 1 2 19 14.3s
DC motor | 7 1 8 5.2s
DC motor with speed sensor | 8 1 9 4.4s
El. Heating Circuit | 1 1 2 4.6s
Hydraulic IsothermalCompressible | 34 34 1m04.3s
ERROR: LoadError: Some tests did not pass: 539 passed, 3 failed, 1 errored, 2 broken.

After:

Test Summary: | Pass Fail Broken Total Time
Core | 572 2 2 576 18m45.7s
Blocks: utils | 14 14 1m02.0s
Blocks: math | 93 93 1m36.3s
Blocks: nonlinear | 15 15 18.0s
Blocks: continuous | 76 76 1m45.8s
Blocks: sources | 63 63 3m35.7s
Blocks: analysis points | 60 60 3m21.7s
Analog Circuits | 81 2 83 2m29.8s
sensors | 4 4 5.3s
voltage divider with a short branch | 6 6 11.5s
RC | 2 2 4.0s
RL | 2 2 3.4s
RC with voltage sources | 12 12 27.1s
RC with current sources | 2 2 3.7s
Integrator | 3 3 6.3s
Voltage function generators | 21 21 15.4s
Current function generators | 21 21 14.4s
Diode component test | 1 1 2 10.6s
HeatingDiode component test | 3 1 4 19.5s
VariableResistor with Temperature Dependency | 4 4 13.9s
Digital Circuits | 34 34 1.3s
Chua Circuit Demo | 1 1 7.3s
Thermal Circuits | 17 17 18.2s
Thermal Demo | 10 10 26.6s
Magnetic | 3 3 5.4s
Mechanical Rotation | 31 31 1m01.5s
Mechanical Translation | 16 16 53.6s
Mechanical Translation Modelica | 7 7 15.8s
Multi-Domain | 17 2 19 17.1s
Hydraulic IsothermalCompressible | 34 34 1m09.7s
ERROR: LoadError: Some tests did not pass: 572 passed, 2 failed, 0 errored, 2 broken.

@AayushSabharwal
Copy link
Member Author

When there's an error outside of a test, the rest of the testset is skipped. So the tests after the error don't run and aren't counted in the total. When the error is fixed, the rest of the tests now run and are counted in the total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants