Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remake for SCCNonlinearProblem #904

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

SebastianM-C
Copy link
Contributor

It looks like the explicitfuns! argument is directly forwarded to the constructor resulting in broken problems after a remake due to explicitfuns! being missing.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

It looks like the `explicitfuns!` argument is directly forwarded to the constructor resulting in broken problems after a remake due to `explicitfuns!` being `missing`.
Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a test somewhere for newprob = remake(prob::SCCNonlinearProblem). Could you check that @test newprob.explicitfuns! !== missing?

@SebastianM-C
Copy link
Contributor Author

SebastianM-C commented Jan 15, 2025

We have a test somewhere for newprob = remake(prob::SCCNonlinearProblem).

I haven't found any test for SCCNonlinearProblem in in the remake tests 😅
I added some minimal tests for remake(prob::SCCNonlinearProblem), let me know what you think.

Edit: Ah, they are in downstream testing. I added the test there.

@AayushSabharwal AayushSabharwal merged commit 7ed01df into SciML:master Jan 16, 2025
28 of 51 checks passed
@SebastianM-C SebastianM-C deleted the patch-1 branch January 16, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants