-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling events in GoogleCharts #100
Changes from 6 commits
7249882
219e560
f05bc14
b362815
a342bc7
454c58b
c3672e0
14ecc63
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,18 +9,24 @@ end | |
|
||
namespace :googlecharts do | ||
desc "Update google charts javascript dependent files, from latest Builds on google developers website" | ||
task :update => [:jsapi, :loader] | ||
task :update => [:loader, :jspdf] | ||
sh "mkdir -p lib/daru/view/adapters/js/googlecharts_js/" | ||
task :jsapi do | ||
say "Grabbing Core from google jsapi codebase..." do | ||
sh "curl -# http://www.google.com/jsapi -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/google_visualr.js" | ||
end | ||
end | ||
# FIXME: Updating jsapi is causing error in IRuby notebook and Googlecharts do not work. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Open an issue to track this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
# task :jsapi do | ||
# say "Grabbing Core from google jsapi codebase..." do | ||
# sh "curl -# http://www.google.com/jsapi -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/google_visualr.js" | ||
# end | ||
# end | ||
|
||
task :loader do | ||
say "Grabbing loader.js from the google website..." do | ||
sh "curl -# http://www.gstatic.com/charts/loader.js -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/loader.js" | ||
end | ||
end | ||
|
||
task :jspdf do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we using it ? |
||
say "Grabbing jspdf.min.js from the cloudfare..." do | ||
sh "curl -# https://cdnjs.cloudflare.com/ajax/libs/jspdf/1.3.5/jspdf.min.js -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/jspdf.min.js" | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChartWrapper here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_listeners_js('wrapper')
in this method was generating rubocop error so I've created another methodextract_chart_wrapper_options
in the common module display.