下载限速 #492
Closed
下载限速 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
（抱歉，我已经很努力忍住不笑了（doge）） |
Scighost
reviewed
Nov 13, 2023
| @@ -733,6 +733,7 @@ private async Task<List<DownloadTask>> GetPkgVersionsAsync(string url) | |||
| public async Task DownloadAsync(CancellationToken cancellationToken) | |||
| { | |||
| const int bufferSize = 1 << 16; | |||
| int speed = AppConfig.DowlondSpeed * 500; | |||
Scighost
reviewed
Nov 13, 2023
| { | ||
| double tempData = ((speedPer - speed) < 1) ? 1 : speedPer - speed; | ||
| int sleepMS = Convert.ToInt32(tempData * (1000 / speed) + 100); | ||
| Thread.Sleep((sleepMS > 1000) ? 1000 : sleepMS); |
Scighost
reviewed
Nov 13, 2023
| Thread.Sleep((sleepMS > 1000) ? 1000 : sleepMS); | ||
| } | ||
| } | ||
| } | ||
| await fs.WriteAsync(buffer.AsMemory(0, length), token).ConfigureAwait(false); | ||
| Interlocked.Add(ref progressBytes, length); |
There was a problem hiding this comment.
因为这部分没有移动到 if (AppConfig.DowlondSpeed != 100) 的 else 分支中，实际下载速度大约是计算值的两倍
Scighost
reviewed
Nov 13, 2023
There was a problem hiding this comment.
你的方法中 DownloadSpeed 参数仅限制了单线程的下载速度，多线程的下载速度总值会远远超过设定值。
|
首先感谢你愿意帮助 Starward 解决一些需要优化的痛点，并且做出了代码贡献。但是因为以上原因我不能接受你的 PR 请求。 |
|
很抱歉之前没看到消息，写的很烂 1. 使用 Thread.Sleep 会阻塞当前线程
2. 没有放到if (AppConfig.DowlondSpeed != 100) 的 else 分支中
3. 多线程
这个方法是判断每一个下载分段与由设置的下载速度计算出的预期分段时间进行比较， |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加下载限速功能
UI没写还有当 DowlondSpeed = 100 时是无限制 单位是Mb/s