Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose user update profile bindings #9418

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Expose user update profile bindings #9418

merged 3 commits into from
Jan 29, 2025

Conversation

AureliaDolo
Copy link
Contributor

Fix #9381

@AureliaDolo AureliaDolo marked this pull request as ready for review January 23, 2025 15:39
@AureliaDolo AureliaDolo requested review from a team as code owners January 23, 2025 15:39
mmmarcos
mmmarcos reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I've made some comments mostly about the tests and the TODOs.

libparsec/crates/client/tests/unit/client/update_user_profile.rs Show resolved Hide resolved
libparsec/crates/client/tests/unit/client/update_user_profile.rs Outdated Show resolved Hide resolved
newsfragments/9381.feature.rst Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
Max-7
Max-7 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Max-7 Max-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good.

@Max-7 Max-7 mentioned this pull request Jan 24, 2025
Open
6 tasks
@AureliaDolo AureliaDolo force-pushed the aurelia/bidings/update_user_profile branch 4 times, most recently from a5ed222 to 78b17d7 Compare January 28, 2025 16:24
@AureliaDolo AureliaDolo added this pull request to the merge queue Jan 29, 2025
@AureliaDolo AureliaDolo removed this pull request from the merge queue due to a manual request Jan 29, 2025
mmmarcos
mmmarcos reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a missing test and some minor suggestions.

libparsec/crates/client/tests/unit/client/update_user_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/tests/unit/client/update_user_profile.rs Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Outdated Show resolved Hide resolved
libparsec/crates/client/src/certif/user_update_profile.rs Show resolved Hide resolved
@AureliaDolo AureliaDolo force-pushed the aurelia/bidings/update_user_profile branch 4 times, most recently from 49a4593 to 961f2fe Compare January 29, 2025 10:49
mmmarcos
mmmarcos approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor typo

libparsec/crates/client/tests/unit/client/update_user_profile.rs Outdated Show resolved Hide resolved
@AureliaDolo AureliaDolo force-pushed the aurelia/bidings/update_user_profile branch from 961f2fe to d91b3dd Compare January 29, 2025 16:12
@AureliaDolo AureliaDolo force-pushed the aurelia/bidings/update_user_profile branch from d91b3dd to 173ec51 Compare January 29, 2025 16:23
@AureliaDolo AureliaDolo enabled auto-merge January 29, 2025 16:24
@AureliaDolo AureliaDolo added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit ea5b765 Jan 29, 2025
15 checks passed
@AureliaDolo AureliaDolo deleted the aurelia/bidings/update_user_profile branch January 29, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Max-7 Max-7 Max-7 approved these changes

@touilleMan touilleMan touilleMan approved these changes

@mmmarcos mmmarcos mmmarcos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bindings for updating user's profile
4 participants
@AureliaDolo @mmmarcos @touilleMan @Max-7