feat(autoupdate): Try decoding invalid hash value with base64 in format_hash
#6272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves base64 decoding process to
format_hash
function, which is formerly infind_hash_in_textfile
andfind_hash_in_headers
, and add debug output before formatting.It will make following effects:
find_hash_in_rdf
: Try decoding invalid hash value with base64.find_hash_in_textfile
: Additionally try decoding invalid hash value found by file name with base64.find_hash_in_json
: Try decoding invalid hash value with base64 (Aimed to solve issue [Feature] Decode base64 hash value fetched in json mode #6271).find_hash_in_xml
: Try decoding invalid hash value with base64.find_hash_in_headers
: Skip decoding if fetched hash value is valid.It should not affect valid hash value that matches the format.
Motivation and Context
Closes #6271
How Has This Been Tested?
Tested with
checkver.ps1
For related issue, use
json
mode in wolai manifest:Contents in url:
Before changes
After changes
Checklist:
develop
branch.