Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing commit #4

Merged
merged 8 commits into from
Jan 20, 2025
Merged

testing commit #4

merged 8 commits into from
Jan 20, 2025

Conversation

chrissycoakley
Copy link
Collaborator

Hi,
I made a change in R which I committed and then pushed to Git.
Now opening a pulll request to move this change to the main branch (going this in Github - web browser).

Assigned Anwen and Euan to see what happens with two reviewers.

@chrissycoakley chrissycoakley self-assigned this Jan 16, 2025
Copy link
Collaborator

@euan9 euan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 + 2 = 3

Merge branch 'chrissy-branch' of https://github.com/ScotGovAnalysis/resas-test into chrissy-branch

# Conflicts:
#	code.R
Copy link
Collaborator

@euan9 euan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/

@chrissycoakley chrissycoakley requested a review from euan9 January 20, 2025 11:45
@chrissycoakley
Copy link
Collaborator Author

While I got the email to say you approved the change I do not seem to be able to commit the change. @euan9 could you try approving the change again?

@euan9 euan9 merged commit cfb97c9 into main Jan 20, 2025
chrissycoakley added a commit that referenced this pull request Jan 20, 2025
Merge pull request #4 from ScotGovAnalysis/chrissy-branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants