Add an option to skip a portion of deletes. Copy the algorithm struct in CompareToOracle. #25
+121,279
−121,252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuuO
changed the title
| if aOF, ok := any(alg).(AlgorithmOnFinish[V, E, M, N]); ok { | ||
| algOracle := alg | ||
| if aN, ok := any(alg).(AlgorithmNew[V, E, M, N, A]); ok { | ||
| algOracle = aN.New() |
There was a problem hiding this comment.
Shouldn't this also be done in the main flow as well as here in the oracle section?
There was a problem hiding this comment.
Yeah you're right. I was assuming the user would have called New() themselves before launching the algorithm.
graph/graph-options.go
Outdated
| @@ -104,6 +106,11 @@ func FlagsToOptions() (graphOptions GraphOptions) { | |||
| tsInterval = uint64(*dEdgePtr) | |||
| } | |||
| deleteOnExpire := (24 * 60 * 60) * uint64(*windowPtr) | |||
| if *skipDelProbPtr != 0 { | |||
| if *skipDelProbPtr < 0 || *skipDelProbPtr >= 1 { | |||
| log.Panic().Msg("sdp must be in the range [0, 1)") | |||
There was a problem hiding this comment.
Suggested change
| log.Panic().Msg("sdp must be in the range [0, 1)") | |
| log.Panic().Msg("Skip deletion probability must be in the range [0, 1)") |
There was a problem hiding this comment.
Thanks! Actually I think this option is still not ready yet because its performance is too bad (due to the linear search). Maybe we should hide this command line option. The max-flow algorithm can now handle deletes efficiently so a simple sliding window should be fine for the evaluation.
LuuO
force-pushed
the
feature/skip-del-prob
branch
from
5080ab1 to
96984f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.