feat: Add IF NOT EXISTS to type alter add statement
#803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
reviewed
Oct 4, 2024
tyt2y3
reviewed
Oct 4, 2024
tyt2y3
added a commit
that referenced
this pull request
Oct 5, 2024
* feat: Add to type alter add statement * Test * Revert --------- Co-authored-by: Chris Tsang <[email protected]>
🎉 Released In 0.31.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
IF NOT EXISTSto type alter add statementBug Fixes
Breaking Changes
TypeAlterOpt::Addvariant to incoporateif_not_exists. I decided to turn it into a struct with named fields to provide clarity on what the boolean means. It's not backwards compatible, but I would assume it would affect few users considering most people would use theTypeAlterStatementdirectly and not the underlying enum.Changes
if_not_existstoTypeAlterStatementif_not_existstoTypeAlterOptprepare_alter_type_optfor clarity and simplicity and to includeIF NOT EXISTS