Address WIF export

[pycanis]

Description

Implements #660

You get on the following screen by clicking on an address in address explorer if WIF export is enabled in settings.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Documentation
• Other

Checklist

• I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms/os:

• Raspberry Pi OS Manual Build
• SeedSigner OS on a Pi0/Pi0W board
• Other

Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.

[fedebuyito]

Hi @pycanis and welcome. Cool job and useful enhancement!

Pytested on 3.10 and 3.12:

I was running it (on emulator) and seems to work fine. However maybe would be useful that this option exports script too, given that Electrum needs "p2pkh:"/"p2wpkh-p2sh:"/"p2wpkh:" to indentify and generate legacy/nested/segwit addresses (otherwise, default case interprets legacy and it could be cumbersome for the others scripts).

Regards!

[fedebuyito]

Something else I am realizing: since it would be a new workflow path, would be desirable to add this case to the workflow tests.

[pycanis]

Hey @fedebuyito, thanks for the review. I was thinking about exporting the script type as well so that it works seamlessly with Electrum wallet but I didn't want to make the assumption that every wallet works the same way, i.e. requires p2wpkh:wif.. format. This solution is supposed to be generic and do what it says it does - export just the WIF.

Regarding the tests, I wasn't able to run them. It's the first time I'm writing python so I don't know the ecosystem and I was getting some dependency errors when I tried to run them. I'll give it another try.

[fedebuyito]

You are right, if the solution is generic. I thinked this for Electrum you quoted on comments and because is the only one of these below which imports WIF single address. But, maybe should be this solution dependent of coordinator software as "export xpub" option does? (only a question I do myself)

Regarding to tests, you can to follow instructions on https://github.com/SeedSigner/seedsigner/blob/dev/tests/README.md, but I needed to work with python venvs for each 3.10/3.12 version or if you would want to use any different dependency:

$ python3.X -m venv your_env_name (where X is python version you going to work)
$ source your_env_name/bin/activate (for to begin work on venv or install dependencies)
$ deactivate (when you want to go out from venv)

This worked for me on Kali Linux. Let me know if need more info.

[pycanis]

I followed the test instructions, was able to install everything but I still get ModuleNotFoundError: No module named 'seedsigner' when running tests.

[fedebuyito]

Which environment/hardware are you running the test on?

[pycanis]

Which environment/hardware are you running the test on?

M1 Macbook. Not using any venv, I ran the commands from https://github.com/SeedSigner/seedsigner/blob/dev/tests/README.md

[fedebuyito]

could you issue this two additional commands before run tests (on your seedsigner folder repo)?

$ git submodule init
$ git submodule update

[pycanis]

It didn't help unfortunately.

[fedebuyito]

It seems to be working on python3.9 version, I think that you must to try with 3.10 or 3.12.

$ python3 --version (to verify default version)

[fedebuyito]

Hi @pycanis , I was trying to reproduce that error and obtained something similar when I ran "./tests/run_full_coverage.sh" command from tests folder, look:

When I run from repo main folder it goes well:

Maybe could be something related to searching path on your system (on mac/python3.9 without venv) (?)

Make sure that you are running ./tests/run_full_coverage.sh command from main repo folder and/or use venv for your pip requeriments install (if you can't worked with 3.10/12 python version yet)

Regards. -

[pycanis]

@fedebuyito thanks for your help, I finally have it working. I've used venv and python version 3.12. I'll write a test or two soon.

[fedebuyito]

Good! I am glad I could support you 🫡. Have you success with tests coding.