Disable tooltip in ReaderControls on Mobile-Web #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent tool tip behavior on mobile browsers This is due to an inconsistent implementation of touch to pseudo states like hover in different browser engines that makes it impossible to use correctly in mobile browsers.
YishaiGlasner
approved these changes
Jan 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the ability to hover over a tooltip in mobile web settings
Code Changes
Use explicit touch/mouse css declarations to disable inconsistent tool tip behavior on mobile browsers
Adds media queries to check for hover implementation and pointer granularity (coarse on touch devices) to make sure only mouse enabled environments respond to hover
Notes
This is due to an inconsistent implementation of touch to pseudo states like hover in different browser engines that makes it impossible to use correctly in mobile browsers. So in Firefox it simply would not show anyway and in Chrome the tooltip would show on touch instead of hover but then get stuck because there is no parallel off "not hover"