Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deepcop[ies] to speed up strengthReduction #66

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

davschneller
Copy link
Contributor

@davschneller davschneller commented Sep 13, 2023

This PR does:

  • removes all deepcopy calls in strengthReduction which were used to support GPU caching for fused GEMMs—by cloning the cost estimator class which unfortunately also meant to copy the whole _cache from the bounding box cost estimator. Instead, we now save a caching set per node, not per cost estimator class.
  • adds some generator expressions, removes some temporary arrays

@davschneller davschneller marked this pull request as ready for review September 13, 2023 06:12
Copy link
Contributor

@krenzland krenzland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, one small question.

yateto/ast/opt.py Outdated Show resolved Hide resolved
@krenzland krenzland merged commit 274b27b into master Sep 13, 2023
5 checks passed
@krenzland krenzland deleted the davschneller/speeding-up branch September 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants