Add support for higher-order JSON descriptions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Ulrich
approved these changes
Mar 27, 2024
| else: | ||
| shape = m['shape'] | ||
| dim = len(shape) | ||
| if len(next(iter(entries))) == dim: |
There was a problem hiding this comment.
next(iter(entries))) will be always the first item of the iteration. Is that what you want?
There was a problem hiding this comment.
As far as I'm aware (it's from the previous code), it's supposed to do exactly that:
- an entry of length
dimwill only encode a sparsity pattern - an entry of length
(dim+1)will encode a value as well
(it's not a very ideal solution, arguably; at least if we consider the special case of null matrices—but so far it worked good enough ... More ideal would probably be to mark the type in the header, next to the tensor shape)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(to match the new format in the SeisSol/Matrices repository)