removed unwrap in update_input for mouse cursor position #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRibera
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Hey @PatrickChodowski thanks a lot for your contribution, can you fix the formatting please so I can merge it as soon as you fix it
SergioRibera
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Firstly, thank you for this package, its awesome, functional and easy to use!
I had one thing bugging me, when I was testing joystick on my desktop using cursor, the game would panic if I accidentally put cursor outside of window. This change fixes it.
It simply doesnt update the position of the cursor if the cursor is outside and seems to be working fine after the cursor is back in window.