Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.15 initial support #32

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Bevy 0.15 initial support #32

merged 7 commits into from
Dec 9, 2024

Conversation

Leinnan
Copy link
Contributor

@Leinnan Leinnan commented Dec 7, 2024

What it does:

  • adds support for newest bevy
  • updates some of the samples

What it does not:

  • updates and confirms that all samples are working
  • updates naming of code to match newest bevy naming

Copy link
Owner

@SergioRibera SergioRibera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you very much for the contribution, it is really nice, I left some comments with suggestions for changes if you like to discuss it, I am totally open to it 😃

.gitignore Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@Leinnan Leinnan requested a review from SergioRibera December 9, 2024 09:22
Copy link
Owner

@SergioRibera SergioRibera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution 🙌🏻

@SergioRibera SergioRibera merged commit 1baecc4 into SergioRibera:main Dec 9, 2024
2 checks passed
@Leinnan
Copy link
Contributor Author

Leinnan commented Dec 9, 2024

No problem! It still requires updating rest of the samples and I would consider updating naming a bit and take more advantage of the introduced requiredComponents feature, but it is a good start for that!

Thanks for creating this useful crate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants