fix: added support for embedded chats #964
Conversation
|
Dead devs xd |
|
need that |
|
Hoping it will be approved @Quoirky! I've got some really useful things I've made for twitch chat that would be even better with 7tv lol! |
|
|
Same, I think the extension will not be updated anymore, and they will create a new one from scratch 🤷 |
Hopefully not, I imagine that they are just undergoing restructuring due to new teams/devs coming in. |
I've got to disappoint you. We're currently not planning to continue using or maintaining any of the old code. We're rewriting it completely from scratch in this monorepo and fixing literally every bug in the process. |
Well, in that case I hope you all consider adding this as a feature! |
| @@ -50,6 +50,7 @@ export async function getManifest(opt: ManifestOptions): Promise<Manifest.WebExt | |||
| { | |||
| matches: ["*://*.twitch.tv/*"], | |||
| js: ["content.js"], | |||
| all_frames: true, | |||
There was a problem hiding this comment.
Does this force a reinstall of the extension?
There was a problem hiding this comment.
No, at least as far as I've seen with testing it locally. It just enables 7tv to detect and work in all twitch frames that aren't the top most frame (In this case it's the embedded iframe)
Is that what you're asking?
There was a problem hiding this comment.
No, I am unsure if this constitutes as a change that will uninstall everyone's extensions so I'm scared to make it.
There was a problem hiding this comment.
Oh yeah no it won't, at least it shouldn't.
There was a problem hiding this comment.
It should just auto update whenever the extension is updated like normal
There was a problem hiding this comment.
I think, we wont fix this on this version and will wait for the rewrite due to be completed within the next few weeks.
There was a problem hiding this comment.
ok, should I just resubmit a pr then or will you guys plan on adding this feature in?
|
Features against this repo wont be implemented, we are going to rewrite the extension on this repo. |
This is a continuation of a previous pull request
I have added
"all_frames":true, to the manifest for URLs that match a chat embed or popup to support embedded iframes showing 7tv emotes.Per Melonifys suggestion I have made it so that it will only work when it detects chat embeds.