fix(twitch): experiment category scroll #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling through the streams inside of a specific category can lock up after initial page load / while scrolling down.
This issue seems to happen because the
AvatarsModulepatches and re-renders the avatars after updating their properties. However, it seems like during re-rendering it grabs a "wrong" virtual node (the scroll container) which breaks the component and thus not allowing the user to scroll. See the following example:7tv_experiment_scroll_non_functional.mp4
which should now work like this:
7tv_experiment_scroll_functional.mp4
This also seems to have fixed the issue that was also fixed in #968
Should fix: #635, fix #977