Feature/realtime_observer #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the sendRequest validation that only allows one of each type to be in the queue. May make this a toggle as the protections are probably wanted for new users
As it appears to only matter for each response type, allow only one to be running at a time and then allow the next one
Having no abilities is actually a valid state for some units
…ates (ocraft#70) * Remove request response type validation Remove the sendRequest validation that only allows one of each type to be in the queue. May make this a toggle as the protections are probably wanted for new users * Add a syncronized based on responsetype As it appears to only matter for each response type, allow only one to be running at a time and then allow the next one * No Abilities is a valid state for a unit Having no abilities is actually a valid state for some units * Adjust observer to see all players intead of only player id 1 * Allow Observers to Filter their own games * Respect Path setting * Add missing observer methods Add a method to set the perspective as well as a method to set what units by unit or tag that we are following * Add Observer Actions * Add method documentation * Add missing imports * Add missing observer action * I forgot another ObserverAction conversion * Revert change to Point2d * Revert Point change * Update ObserverActionInterfaceImpl.java * Update ObserverActionInterface.java * Update Test
…feature/realtime-observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make this PR to help improving the streaming observer by providing a close to realtime alternative without lags.